Install software-properties-common for xenial #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tphoney This works for me, I don't think it introduces any regressions but we should run the Beaker tests though. |
|
I've now also included changes to the README to reflect the implementation and test fixes. The functionality remains unchanged, however. |
|
@imphil Please squash this into a single commit. |
Instead of adding every newer release of Ubuntu, let's assume that the package name that is used today will be used in the future, until the next change is necessary.
|
@daenney done |
|
@bmjen What about you? |
|
LGTM Thanks for the work @imphil |
joshuaspence
pushed a commit
to joshuaspence/dotfiles
that referenced
this pull request
May 15, 2016
This brings in the following changes which I have deemed to be useful: - [[puppetlabs/puppetlabs-apt#604 | #604: Fix version check on 16.04]] - [[puppetlabs/puppetlabs-apt#605 | #605: Install `software-properties-common` for `xenial`]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding every newer release of Ubuntu, let's assume that the
package name that is used today will be used in the future, until the
next change is necessary.