[MODULES-3562] Implement retry for tests which require modules to pull key from keyserver #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eputnam
reviewed
Oct 19, 2016
| # Params: | ||
| # - max_retry_count - Max number of retries | ||
| # - retry_wait_interval_secs - Number of seconds to wait before retry | ||
| # - error_matches - Matcher which the exception raised must match to allow retry |
There was a problem hiding this comment.
did you mean for this to be "error_matcher"?
There was a problem hiding this comment.
Have updated to amend that typo now @eputnam
|
Travis failures are due to the current issue with parallels version 2.10.0 requiring Ruby > 2.0 which is waiting to be addressed this sprint using modulesync across all modules. I didn't touch the module itself of spec tests, just acceptance. |
…imes times out (transient error)
wilson208
force-pushed
the
key-server-timeout-fix
branch
from
dc697e9 to
57c7b88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a function retry_on_error_matching and makes use of that function within tests which are pulling a key from 'hkps.pool.sks-keyservers.net'. These tests were failing occasionally in jenkins when the key server timed out. These changes implement a retry when the error returned is a timeout error.
Whilst making these changes, I found that the tests were incorrectly testing for idempotency so this has been fixed in the first commit.