Ensure release allows empty strings #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelenCampbell
changed the title
HelenCampbell
force-pushed
the
emptystringing
branch
2 times, most recently
from
e7280cb to
29d39cc
Compare
HelenCampbell
changed the title
HelenCampbell
force-pushed
the
emptystringing
branch
from
29d39cc to
2d8ded1
Compare
HelenCampbell
force-pushed
the
emptystringing
branch
2 times, most recently
from
8c65cff to
91fcef7
Compare
HelenCampbell
changed the title
HelenCampbell
force-pushed
the
emptystringing
branch
2 times, most recently
from
90f60e4 to
3128fa7
Compare
Test added to make sure when release is set to an empty string the source file is rendered correctly.
HelenCampbell
force-pushed
the
emptystringing
branch
from
3128fa7 to
cd15d61
Compare
|
yay structured facts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures $release now accepts empty strings as a value without failing and addition of test