Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a facter fact for dist-upgrade #719

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

willmeek
Copy link

@willmeek willmeek commented Nov 7, 2017

This commit adds a facter fact for dist-upgrade, along with
associated facter facts.

(Builds upon PR #634 - adds a new set of facts to maintain compatibility)

@eputnam
Copy link

eputnam commented Nov 7, 2017

i took a peek at tests. may have something to do with scoping in RSpec. while i was testing apt_dist_has_updates_spec.rb, the fact was returning nil, not even false for the last example but putting File.expects(:executable?).with('/usr/bin/apt-get').returns true in the actual example (instead of the before block), it seemed to help a little.

@willmeek
Copy link
Author

willmeek commented Nov 8, 2017

@eputnam I can't replicate this, if I add the expect outside of the block then it returns nil, the opposite of what you are seeing. Travis has gone green too. Let's discuss this later.

@eputnam eputnam removed the tests-fail label Nov 8, 2017
Copy link

@eputnam eputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a Facts section in the readme, would you mind updating that?

This commit adds a facter fact for dist-upgrade, along with
associated facter facts.
@willmeek
Copy link
Author

willmeek commented Nov 8, 2017

Facts in readme updated, thanks

@eputnam eputnam removed the needs-docs label Nov 8, 2017
@willmeek
Copy link
Author

willmeek commented Nov 9, 2017

Thanks @eputnam

@david22swan david22swan merged commit b3d1148 into puppetlabs:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants