Support managing login configurations in /etc/apt/auth.conf #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APT 1.5 formally introduced support for specifying login configuration settings (like username and password) for APT sources or proxies that require authentication in the file `/etc/apt/auth.conf`. This file follows a netrc-like format (like ftp or curl) and has restrictive permissions. This is preferable to embedding login information directly in sources.list entries (which are usually world-readable). See https://manpages.debian.org/testing/apt/apt_auth.conf.5.en.html for details. This change adds a new, optional class parameter `apt::auth_conf_entries` which expects an array of hashes (defined by a new abstract data type `Apt::Auth_conf_entry`) that represent sets of login configuration settings to record in `/etc/apt/auth.conf`. The file's contents are rendered using a simple EPP template. Contains updated spec tests and documentation.
antaflos
force-pushed
the
apt_auth_conf_support
branch
from
f69e64c to
d4e1a34
Compare
|
Updated PR with Rubocop fixes. |
|
It seems acceptance tests are failing but apparently not because of the changes in this PR. |
|
I'll close and re-open the PR so that Travis runs the tests again, maybe the errors were caused by transient problems. |
|
It seems the acceptance tests are broken, and I don't think this error is related to my changes: Apparently the remote FTP server from which the APT key should be fetched doesn't like Travis or Docker IP addresses (probably something about passive mode). |
|
closing, and re-openning to force travis to re-kick |
DavidS
approved these changes
Jun 21, 2018
|
Great work @antaflos !!! love it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APT 1.5 formally introduced support for specifying login configuration
settings (like username and password) for APT sources or proxies that
require authentication in the file
/etc/apt/auth.conf. This filefollows a netrc-like format (like ftp or curl) and has restrictive
permissions. This is preferable to embedding login information directly
in sources.list entries (which are usually world-readable). See
https://manpages.debian.org/testing/apt/apt_auth.conf.5.en.html for
details.
This change adds a new, optional class parameter
apt::auth_conf_entrieswhich expects an array of hashes (defined by anew abstract data type
Apt::Auth_conf_entry) that represent sets oflogin configuration settings to record in
/etc/apt/auth.conf. Thefile's contents are rendered using a simple EPP template.
Contains updated spec tests and documentation.