(maint) make apt testing more stable, cleanup #764
Conversation
tphoney
force-pushed
the
stabilise_acceptance_tests
branch
19 times, most recently
from
02f5fb4 to
c9b3f0f
Compare
|
This seems to fix most of our jenkins / ci issues, as well as clean up the code and tests. |
tphoney
force-pushed
the
stabilise_acceptance_tests
branch
3 times, most recently
from
0cc1ae8 to
04e8299
Compare
tphoney
force-pushed
the
stabilise_acceptance_tests
branch
from
04e8299 to
ca31cab
Compare
|
Hi @tphoney @HelenCampbell. Is there already a plan for a new release? We would like to see one since this PR fixes some of our issues with ubuntu 18.04: voxpupuli/puppet-zabbix#500 (comment) |
|
We would also appreciate a new releases which contains this fix! :) |
|
Its on our back log https://tickets.puppetlabs.com/browse/MODULES-7337 |
|
:) |
| @@ -29,17 +28,9 @@ | |||
| $_release = $release | |||
| } | |||
|
|
|||
| # Some releases do not support https transport with default installation | |||
There was a problem hiding this comment.
Removal of this is a regression. It's a feature we depend on.
There was a problem hiding this comment.
https://tickets.puppetlabs.com/browse/MODULES-7540 has been created, this was my fault. I have a fix incoming, and will start a release soon after.
There was a problem hiding this comment.
Thanks, just ran into it but hadn't had time to create an issue myself. Luckily for me I noticed it on a CI job and not in production.
No description provided.