Introduce an Apt::Proxy type to validate the hash

[ekohl]

No description provided.

[pmcmaw]

Hey @ekohl

Would it be possible to add some tests and documentation around this new functionality and I will work on getting it merged.

:-)

[ekohl]

puppetlabs-apt/spec/classes/apt_spec.rb

Lines 80 to 156 in bdc285a

	describe 'proxy=' do
	context 'when host=localhost' do
	let(:params) { { proxy: { 'host' => 'localhost' } } }
	it {
	is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
	%r{Acquire::http::proxy "http://localhost:8080/";},
	).without_content(
	%r{Acquire::https::proxy},
	)
	}
	end
	context 'when host=localhost and port=8180' do
	let(:params) { { proxy: { 'host' => 'localhost', 'port' => 8180 } } }
	it {
	is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
	%r{Acquire::http::proxy "http://localhost:8180/";},
	).without_content(
	%r{Acquire::https::proxy},
	)
	}
	end
	context 'when host=localhost and https=true' do
	let(:params) { { proxy: { 'host' => 'localhost', 'https' => true } } }
	it {
	is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
	%r{Acquire::http::proxy "http://localhost:8080/";},
	).with_content(
	%r{Acquire::https::proxy "https://localhost:8080/";},
	)
	}
	end
	context 'when host=localhost and direct=true' do
	let(:params) { { proxy: { 'host' => 'localhost', 'direct' => true } } }
	it {
	is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
	%r{Acquire::http::proxy "http://localhost:8080/";},
	).with_content(
	%r{Acquire::https::proxy "DIRECT";},
	)
	}
	end
	context 'when host=localhost and https=true and direct=true' do
	let(:params) { { proxy: { 'host' => 'localhost', 'https' => true, 'direct' => true } } }
	it {
	is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
	%r{Acquire::http::proxy "http://localhost:8080/";},
	).with_content(
	%r{Acquire::https::proxy "https://localhost:8080/";},
	)
	}
	it {
	is_expected.to contain_apt__setting('conf-proxy').with(priority: '01').with_content(
	%r{Acquire::http::proxy "http://localhost:8080/";},
	).without_content(
	%r{Acquire::https::proxy "DIRECT";},
	)
	}
	end
	context 'when ensure=absent' do
	let(:params) { { proxy: { 'ensure' => 'absent' } } }
	it {
	is_expected.to contain_apt__setting('conf-proxy').with(ensure: 'absent',
	priority: '01')
	}
	end
	end

already has positive tests. I was sort of trusting the Puppet type system here but I could add a negative test if desired.

Note that the same pattern of verifying hashes is used in a lot of places in this module so there's a lot more that could be replaced in the same way but I didn't have time for that.

[pmcmaw]

Nope testing wise thats fine @ekohl I think thats fair.
Would it be possible to add a small README entry under the defined types section.

Also thanks for the quick response! :-)

[david22swan]

Have updated the readme to get this merged

[ekohl]

Thanks @david22swan. This sort of dropped of my radar for a bit. I must say I really like the Puppet 4 type system. Powerful yet straight forward to use.

[HelenCampbell]

Thank for your contribution @ekohl ! The Puppet 4 type system is awesome :D