Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-8272) - Revert "Autorequire dirmngr in apt_key types" #825

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

eimlav
Copy link

@eimlav eimlav commented Nov 20, 2018

A bug has been introduced through this commit which creates a dependency cycle in Debian 9 when applying a simple manifest. This reverts commit 53ea6e7.

@eimlav eimlav added the bugfix label Nov 20, 2018
@eimlav eimlav changed the title [WIP] (MODULES-8272) - Revert "Autorequire dirmngr in apt_key types" (MODULES-8272) - Revert "Autorequire dirmngr in apt_key types" Nov 20, 2018
@pmcmaw pmcmaw merged commit 1a8a3cc into puppetlabs:master Nov 20, 2018
@eimlav eimlav deleted the dirmngr-fix branch November 20, 2018 12:45
@ekohl
Copy link
Collaborator

ekohl commented Dec 3, 2018

I'm very disappointed that as the original author of the patch I wasn't CCed.

AFAIK the current code (after reverting) doesn't properly ensure dirmngr is actually installed when it's needed. There isn't a test case that verifies the regression isn't re-introduced when the dependency is actually added so I'm wondering if this isn't actually a bug in how it's called.

@eimlav
Copy link
Author

eimlav commented Dec 4, 2018

@ekohl Apologies for not notifying you of the change. Unfortunately, this change was causing dependency cycles in Debian 9 and notable failures in PuppetDB. We decided that the best course of action was to remove the change and do a patch release as a large number of users depend on PuppetDB. However in saying that, we are still aware that this is a present issue with the module and it will be investigated in the foreseeable future (associated ticket).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants