Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10583) Revert "MODULES-10548: make files readonly" #920

Merged
merged 1 commit into from
Mar 10, 2020
Merged

(MODULES-10583) Revert "MODULES-10548: make files readonly" #920

merged 1 commit into from
Mar 10, 2020

Conversation

carabasdaniel
Copy link

@carabasdaniel carabasdaniel commented Mar 9, 2020

This reverts commit ab2e06b.

These changes are causing the module to cause undesired behaviour according to ticket MODULES-10583.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #920 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files           5        5           
  Lines         260      260           
=======================================
  Hits          190      190           
  Misses         70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1706d...316fd8f. Read the comment docs.

@carabasdaniel carabasdaniel marked this pull request as ready for review March 10, 2020 10:28
@carabasdaniel carabasdaniel requested a review from a team as a code owner March 10, 2020 10:28
@DavidS DavidS added the bugfix label Mar 10, 2020
@DavidS DavidS changed the title Revert "MODULES-10548: make files readonly" (MODULES-10583) Revert "MODULES-10548: make files readonly" Mar 10, 2020
Copy link

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidS DavidS merged commit ba65bec into puppetlabs:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants