Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10763) loglevel won't affect reports #942

Merged
merged 1 commit into from
Aug 5, 2020
Merged

(MODULES-10763) loglevel won't affect reports #942

merged 1 commit into from
Aug 5, 2020

Conversation

gguillotte
Copy link

The README suggests that setting a sufficiently high loglevel metaparameter
value will squelch the Exec[apt_update] resource's corrective changes from
agent reports. This is not true. Correct and clarify this statement to limit
its scope to log output, and link to MODULES-10763 for context on the exec
resource's false-positive reporting of corrective changes as a known issue.

The README suggests that setting a sufficiently high `loglevel` metaparameter
value will squelch the `Exec[apt_update]` resource's corrective changes from
agent reports. This is not true. Correct and clarify this statement to limit
its scope to log output, and link to MODULES-10763 for context on the exec
resource's false-positive reporting of corrective changes as a known issue.
@gguillotte gguillotte requested a review from a team as a code owner August 4, 2020 16:27
@gguillotte
Copy link
Author

For additional context, see the post-merge comments on the PR that introduced this note to the README: #690 (comment)

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@841e282). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage        ?   71.86%           
=======================================
  Files           ?        5           
  Lines           ?      263           
  Branches        ?        0           
=======================================
  Hits            ?      189           
  Misses          ?       74           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841e282...c646305. Read the comment docs.

@pmcmaw
Copy link

pmcmaw commented Aug 5, 2020

Hey @gguillotte :-) thank you for your PR.
Merging.

@pmcmaw pmcmaw merged commit 1f8a767 into puppetlabs:main Aug 5, 2020
@pmcmaw pmcmaw added the bugfix label Aug 11, 2020
@gguillotte gguillotte deleted the clarify-loglevel branch August 12, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants