Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the PPA code for changes in Quantal #96

Merged
merged 1 commit into from
Nov 30, 2012
Merged

Modified the PPA code for changes in Quantal #96

merged 1 commit into from
Nov 30, 2012

Conversation

jnicolson
Copy link

In Quantal the add-apt-repository tool is no longer in the python-software-properties package but is in software-properties-common. This commit adds a check in the manifest for pre-precise and then adds some new tests for quantal.

One of my first attempts at changes to a puppet manifest and my first ever attempt at tests, so forgive my code!

@michfield
Copy link

C'mon. Let's merge this already. Why it's taking so long?

add-apt-repository is being moved from python-software-properties to the software-properties-common package.

in Quantal. Source: https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1021418

I'm using this module, and now I have to switch to another one.

@branan
Copy link

branan commented Nov 30, 2012

I'm sorry it's taken us so long to review this. I'm looking over it now, and we'll try to get this merged and get a new release cut ASAP.

branan pushed a commit that referenced this pull request Nov 30, 2012
Modified the PPA code for changes in Quantal
@branan branan merged commit e7cbcb6 into puppetlabs:master Nov 30, 2012
@branan
Copy link

branan commented Nov 30, 2012

I'll comment here when this patch is available in a released version.

@branan
Copy link

branan commented Dec 3, 2012

puppetlabs-apt has had a 1.1.0 release which includes this patch. See http://forge.puppetlabs.com/puppetlabs/apt/1.1.0

@LukasAud LukasAud added the bugfix label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants