Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt::source: pass the weak_ssl param to apt::key #993

Merged
merged 1 commit into from
Jul 26, 2021
Merged

apt::source: pass the weak_ssl param to apt::key #993

merged 1 commit into from
Jul 26, 2021

Conversation

kenyon
Copy link

@kenyon kenyon commented Jul 21, 2021 •
edited
Loading

If you're creating apt::source resources with hiera, without this commit, there's no way to pass the weak_ssl parameter to the apt::key resource.

Also added weak_ssl to a test.

@kenyon kenyon requested a review from a team as a code owner July 21, 2021 20:29
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

apt::source is a type

Breaking changes to this file WILL impact these 328 modules (exact match):
Breaking changes to this file MAY impact these 87 modules (near match):

This module is declared in 234 of 577 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@daianamezdrea
Copy link

Hi @kenyon, this looks good, thank you ! Cheers !

@daianamezdrea daianamezdrea merged commit fcb2ba5 into puppetlabs:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daianamezdrea daianamezdrea daianamezdrea approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenyon @CLAassistant @daianamezdrea