Validate global_options and defaults_options. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlimoncelli
force-pushed
the
validate_hash_options
branch
3 times, most recently
from
f89ce6f to
d035857
Compare
* validate_hash() global_options and defaults_options * Add spec tests to verify that non-hash values produce errors * Add spec test to verify functionality of non-merge behavior
tlimoncelli
force-pushed
the
validate_hash_options
branch
from
d035857 to
478b029
Compare
|
This is ready to be considered for merge. This fixes https://tickets.puppetlabs.com/browse/MODULES-2857 |
| # For testing the merging functionality we restrict ourselves to | ||
| # Debian OS family so that we don't have to juggle different sets of | ||
| # global_options and defaults_options (like for FreeBSD). | ||
| ['Debian' ].each do |osfamily| |
There was a problem hiding this comment.
Thanks for raising that. I'm copying the style of this kind of test above on line 373 (https://github.com/puppetlabs/puppetlabs-haproxy/pull/207/files#diff-7be58596f7d58684b9342fe66e3aeee3L373)
DavidS
added a commit
that referenced
this pull request
Dec 7, 2015
Validate global_options and defaults_options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: This validation would have prevented a minor outage we had after upgrading to the latest commit. Hopefully by adding this validate_*() other users will not suffer like we did.
The documentation clearly states that defaults_options must be a hash but we had been sending it an array. This worked in the old code but not the new code. Oops!