(MODULES-8566) Only create entries for defined settings #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@genebean Unfortunately your changes are currently failing the unit tests |
genebean
force-pushed
the
resolver_template_conditional
branch
from
855b875 to
19f48ec
Compare
|
@david22swan I don't know why I have such a hard time remembering to to |
|
|
|
@genebean Don't worry about it, can't tell you how many times I've made a pr ony to notice it failing on the rubocop check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that
templates/haproxy_resolver_block.erbonly creates config entries for values that the user has specified. All other values can have defaults provided by HAProxy