Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bugfix) backend: dont log warnings if not necessary #449

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

bastelfreak
Copy link
Collaborator

this is a follow-up for #442

with the current code in the main branch, a warning is logged to the
puppetserver.log for every backend, if httpchk is set. This is very
noisy and provides 0 benefit, if the user set the
sort_options_alphabetic to false.

this is a follow-up for puppetlabs#442

with the current code in the main branch, a warning is logged to the
puppetserver.log for every backend, if httpchk is set. This is very
noisy and provides 0 benefit, if the user set the
sort_options_alphabetic to false.
@bastelfreak bastelfreak requested a review from a team as a code owner November 19, 2020 09:45
@puppet-community-rangefinder
Copy link

haproxy::backend is a type

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 40 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@0a937ee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage        ?   16.66%           
=======================================
  Files           ?        1           
  Lines           ?        6           
  Branches        ?        0           
=======================================
  Hits            ?        1           
  Misses          ?        5           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a937ee...de86442. Read the comment docs.

@adrianiurca adrianiurca changed the title backend: dont log warnings if not necessary (maint) backend: dont log warnings if not necessary Nov 23, 2020
@adrianiurca
Copy link

Hi @bastelfreak, thank you for your contribution!

kind regards,
@adrianiurca

@adrianiurca adrianiurca merged commit 5b88d2f into puppetlabs:main Nov 23, 2020
@adrianiurca adrianiurca changed the title (maint) backend: dont log warnings if not necessary (bugfix) backend: dont log warnings if not necessary Nov 23, 2020
@bastelfreak bastelfreak deleted the pain branch September 9, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants