Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding chroot_dir_manage parameter. #498

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Adding chroot_dir_manage parameter. #498

merged 2 commits into from
Sep 13, 2021

Conversation

Tamerz
Copy link

@Tamerz Tamerz commented Aug 29, 2021

This PR adds a chroot_dir_manage parameter to the haproxy::instance and haproxy::config defined types.

I added it because the default permissions for the chroot directory on RHEL is owned by root. Changing it to the 'haproxy' user causes SELinux problems. I prefer leaving the directory owned by root.

@Tamerz Tamerz requested a review from a team as a code owner August 29, 2021 09:02
@puppet-community-rangefinder
Copy link

haproxy::config is a type

that may have no external impact to Forge modules.

haproxy::instance is a type

that may have no external impact to Forge modules.

This module is declared in 40 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@Tamerz Tamerz closed this Aug 29, 2021
@Tamerz Tamerz reopened this Aug 29, 2021
@puppet-community-rangefinder
Copy link

haproxy::config is a type

that may have no external impact to Forge modules.

haproxy is a class

Breaking changes to this file WILL impact these 10 modules (exact match):
Breaking changes to this file MAY impact these 5 modules (near match):

haproxy::instance is a type

that may have no external impact to Forge modules.

This module is declared in 40 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021

CLA assistant check
All committers have signed the CLA.

@sheenaajay
Copy link

Thanks @Tamerz for submitting the PR.

@daianamezdrea daianamezdrea merged commit ad776e4 into puppetlabs:main Sep 13, 2021
@Tamerz Tamerz deleted the chrootdir branch September 13, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants