Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying mapfile entries to be collected later #508

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

yakatz
Copy link

@yakatz yakatz commented Feb 28, 2022

This will allow declaring mapfile entries separately and collecting them later.

Example usage:

@haproxy::mapfile::entry { 'example.com dotcom-backend':
    mapfile => 'shared-hosting',
}
haproxy::mapfile { 'shared-hosting':
    ensure   => 'present',
}

Haproxy::Mapfile::Entry <| mapfile == 'shared-hosting' |>

@yakatz yakatz requested a review from a team as a code owner February 28, 2022 06:28
@puppet-community-rangefinder
Copy link

haproxy::mapfile is a type

that may have no external impact to Forge modules.

haproxy::mapfile::entry is a type

that may have no external impact to Forge modules.

This module is declared in 40 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@yakatz yakatz force-pushed the feature/allow_collecting_maps branch 2 times, most recently from b76dbf9 to 01512e9 Compare February 28, 2022 14:32
@github-actions
Copy link

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label May 10, 2022
@yakatz
Copy link
Author

yakatz commented May 10, 2022

I would appreciate some feedback on why the tests are failing

@github-actions github-actions bot removed the stale label May 11, 2022
@petergmurphy
Copy link

Hi yakatz,

I've been looking into why your tests are failing. I've rebased your code off upstream/main and made appropriate changes to it on my own fork.

With these changes the acceptance tests are now passing on my local test environment with Ubuntu 20.04 and Puppet 7. If these changes look satisfactory to you, let me know and I can add them to your code.

Peter

@yakatz
Copy link
Author

yakatz commented May 30, 2022

With these changes the acceptance tests are now passing on my local test environment with Ubuntu 20.04 and Puppet 7.

Hi Peter,
The tests pass on my local machine already, but there is something different about the CI environment. I am looking at your changes now.

@yakatz yakatz force-pushed the feature/allow_collecting_maps branch from ced9656 to 3169982 Compare May 30, 2022 15:21
@yakatz
Copy link
Author

yakatz commented May 30, 2022

With these changes the acceptance tests are now passing on my local test environment with Ubuntu 20.04 and Puppet 7. If these changes look satisfactory to you, let me know and I can add them to your code.

Hi Peter,
It looks like you missed the point of test - there should be a single frontend that selects a backend based on the mapfile.

@yakatz yakatz force-pushed the feature/allow_collecting_maps branch from 5b745a5 to e3fc532 Compare May 30, 2022 19:00
@yakatz yakatz force-pushed the feature/allow_collecting_maps branch from e3fc532 to 5175e8e Compare May 30, 2022 19:01
@yakatz
Copy link
Author

yakatz commented May 31, 2022

Failed test is a litmus:provision error... Everything else passed 🎉

@petergmurphy
Copy link

Nice work getting everything passing. I'll get this merged now! 🎉

@petergmurphy petergmurphy merged commit f2ab613 into puppetlabs:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants