Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Cont 779) Add Support for Puppet 8 / Drop Support for Puppet 6 #544

Merged
merged 11 commits into from
Apr 3, 2023
Merged

(Cont 779) Add Support for Puppet 8 / Drop Support for Puppet 6 #544

merged 11 commits into from
Apr 3, 2023

Conversation

david22swan
Copy link
Member

  • Includes an update which pins all Rubocop versions to their newest possible version.

@david22swan david22swan requested a review from a team as a code owner March 27, 2023 10:43
@david22swan david22swan force-pushed the CONT-780/main/puppet_8 branch 9 times, most recently from 1dc162b to 107a3a0 Compare March 31, 2023 09:54
@david22swan
Copy link
Member Author

Remaining rubocop rules in TODO are being left in place due to time requirements with the Puppet 8 work.
Being kept in TODO rather than returned to the rubocop.yml to ensure their visability

david22swan added 11 commits April 3, 2023 09:39
@david22swan
(CONT-780) Move Puppet version support
c76bd05
@david22swan
(CONT-779) Unpin puppet_agent
756a0b9
@david22swan
(CONT-799) Unpin puppet_litmus
fbc5567
@david22swan
(MAINT) PDK Update
4a8ec94
@david22swan
(CONT-799) Update Rubocop Versions
7851361 
New Versions:
rubocop = 1.48.1
rubocop-performance = 1.16.0
rubocop-rspec = 2.19.0

Also includes the reactivation of all previously disabled Cops
@david22swan
(CONT-799) Rubocop Fixes 1-3
45acb6f 
- Layout/ClosingHeredocIndentation
- Layout/EmptyLineAfterGuardClause
- Layour/HashAlignment
@david22swan
(CONT-799) Legacy Fact Fix
d230c18
@david22swan
(CONT-799) Rubocop Fixes 4-9
1562a54 
- Lint/RedundantCopEnableDirective
- Style/IfUnlessModifier
- Style/RedundantRegexpEscape
- Style/RedundantStringEscape
- Style/RescueStandardError
@david22swan
(CONT-799) Rubocop Fixes 10-12
9144a50 
- Rspec/EmptyLineAfterExample
- Rspec/EmptyLineAfterExampleGroup
- Style/TrailingCommaHashLiteral
@david22swan
(CONT-799) Rubocop Fixes 13-15
9446785 
- RSpec/ContextWording
- RSpec/ExampleLength
- RSpec/MultipleExpectations
@david22swan
((CONT-799) Rubocop Fixes 16-20
0db7f4d 
- Rspec/MultipleMemorizedHelpers
- Rspec/NestedGroups
- RspecRepeatedExampleGroupBody
- Rspec/RepeatedExampleGroupDescription
- Style/MixinUsage
@david22swan david22swan force-pushed the CONT-780/main/puppet_8 branch from 0330c25 to 0db7f4d Compare April 3, 2023 08:39
GSPatton
GSPatton approved these changes Apr 3, 2023
View reviewed changes
Copy link

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good to me

@GSPatton GSPatton merged commit 30699c2 into main Apr 3, 2023
@GSPatton GSPatton deleted the CONT-780/main/puppet_8 branch April 3, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSPatton GSPatton GSPatton approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @GSPatton