Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minus in service names #60

Merged
merged 3 commits into from
Nov 18, 2013
Merged

Support minus in service names #60

merged 3 commits into from
Nov 18, 2013

Conversation

ymc-dabe
Copy link

This pull request contains the changes from #36 and was rebased on current master. Additionally it updates corresponding rspec examples.

vatlidak and others added 3 commits November 14, 2013 14:14
Correct the order with which concat fragments of listening services are collected. The previous implementation could result to wrong configuration files. 

Example:

Suppose you have two backend members named lxbrf23, lxbrf24 and the listening services: 
-demoservice
-demoservice-mess
-demoservice-mess-it
-demoservice-mess-it-even
-demoservice-mess-it-even-more

The concat fragments will be alphanumerically ordered and will result to a wrong configuration file.
...since current master of puppetlabs-concat breaks tests.
...which recently was introduced to support services with minus in their name.
apenney pushed a commit that referenced this pull request Nov 18, 2013
@apenney apenney merged commit 0d4c50e into puppetlabs:master Nov 18, 2013
@ymc-dabe ymc-dabe deleted the support-minus-in-service-names branch November 19, 2013 07:38
@ymc-dabe
Copy link
Author

@apenney That was pretty fast, thanks a lot! (btw: you might want to close #36 - see: #36 (comment))

resmo pushed a commit to swisstxt/puppet-platform-services that referenced this pull request Jan 14, 2014
Introduced by SRF, since we need support for minus in service names in haproxy.
For more details take a look at:
puppetlabs/puppetlabs-haproxy#60
resmo pushed a commit to swisstxt/puppet-platform-services that referenced this pull request Jan 14, 2014
Since puppetlabs merged our pull request (#60):
- Switched back to https://github.com/puppetlabs/puppetlabs-haproxy.git
- Set submodule haproxy to commit 0d4c50ed56f4fce06b66c04611cebec29f7a37a8 (which is current head of branch master)

More information can be found at: puppetlabs/puppetlabs-haproxy#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants