Improve download task gpg verification #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterating on this task to ensure it behaves well in an air-gapped environment by default. * Start by downloading the .asc file, always. If we don't re-download that file, we aren't really verifying anything. * Use the .asc file to try and verify existing content. Distinguish between service-not-available (such as gpg not present, or unable to reach keyserver) and verification failure. * If unable to retrieve the .asc file, or if service-not-available, fall back to size-verification. * Parameterize the key ID and key server values, to keep the download task plausibly generic, and not just for downloading the PE tarball.
reidmv
force-pushed
the
iterate-on-download-verify
branch
from
23a208e to
f31b6ae
Compare
ody
reviewed
Sep 10, 2021
There was a problem hiding this comment.
If I expect the task to verify the download and am not aware that I can't fetch keys then the only way I know it skipped verification and fell back to old size comparison is by reading logs. My expectation is that it would fail if it couldn't verify and I the user would have to pass a "verify_fallback" option to explicitly accept old behavior or go through the work of manually importing the correct things ahead of time
ody
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating on this task to ensure it behaves well in an air-gapped
environment by default.
that file, we aren't really verifying anything.
between service-not-available (such as gpg not present, or unable to
reach keyserver) and verification failure.
fall back to size-verification.
task plausibly generic, and not just for downloading the PE tarball.