Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for plan peadm::add_compiler over pcp transport #356

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Fix for plan peadm::add_compiler over pcp transport #356

merged 7 commits into from
Oct 10, 2023

Conversation

jortencio
Copy link
Contributor

@jortencio jortencio commented May 24, 2023 •
edited
Loading

The plan peadm::add_compiler has been updated to make use of the peadm::subplans::component_install so that it doesn't error when run over PCP transport. This also makes the management of the agent installation consistent with peadm::add_database and peadm::add_replica plans.

In addition, updates were made to peadm::subplans::component_install as the trusted facts set for compilers are different to other Puppet infrastructure roles and updates were made to peadm::subplan::agent_install to add dns-alt-names to the certificate if provided.

Closes #355

@jortencio jortencio requested review from a team as code owners May 24, 2023 23:50
@CLAassistant
Copy link

CLAassistant commented May 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CoMfUcIoS
Copy link
Contributor

There are a lot of changes since this PR was created, can you please rebase it?

@jortencio
Copy link
Contributor Author

@CoMfUcIoS As requested I have rebased my branch

ragingra
ragingra approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ragingra ragingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested the the add compiler plan and worked over pcp

@CoMfUcIoS CoMfUcIoS merged commit 5e2fbd1 into puppetlabs:main Oct 10, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoMfUcIoS CoMfUcIoS CoMfUcIoS approved these changes

@ragingra ragingra ragingra approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

peadm::add_compiler not working using PCP transport
4 participants
@jortencio @CLAassistant @CoMfUcIoS @ragingra