Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Update PEADM with 2023.6 support #419

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Jo-Lillie
Copy link
Contributor

@Jo-Lillie Jo-Lillie commented Feb 7, 2024

Summary

Update to 2023.6.0 support

Updating default install version to 2021.7.7

Updating default from 2021.7.6 to 2021.7.7

Updated tests to match latest LTS version

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@Jo-Lillie Jo-Lillie requested review from a team as code owners February 7, 2024 11:53
@CoMfUcIoS
Copy link
Contributor

You need also to bump the LTS version to PE 2021.7.7! Also in tests!

@Jo-Lillie Jo-Lillie force-pushed the maint-update-peadm-with-2023.6-support branch from 2067c6b to 071c9e0 Compare February 7, 2024 13:00
Copy link
Member

@ragingra ragingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@cathal41 cathal41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all green, SHIP IT!

@Jo-Lillie Jo-Lillie merged commit 1ef0fb8 into main Feb 7, 2024
49 checks passed
@Jo-Lillie Jo-Lillie deleted the maint-update-peadm-with-2023.6-support branch February 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants