Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-37233) Adding add_compiler to test matrix #434

Merged
merged 1 commit into from
May 14, 2024

Conversation

ragingra
Copy link
Member

Summary

Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@ragingra ragingra force-pushed the PE-37233_AddCompilerTestMatrix branch 2 times, most recently from 55fec12 to 3eb8497 Compare April 30, 2024 18:27
Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler
@ragingra ragingra force-pushed the PE-37233_AddCompilerTestMatrix branch from 3eb8497 to cbdf423 Compare April 30, 2024 19:10
@ragingra ragingra marked this pull request as ready for review May 1, 2024 08:52
@ragingra ragingra requested review from a team as code owners May 1, 2024 08:52
Copy link
Contributor

@Jo-Lillie Jo-Lillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran actions on standard and XL - lgtm 👍

@ragingra ragingra merged commit 21dbb5d into add_compiler_supported May 14, 2024
7 of 8 checks passed
@ragingra ragingra deleted the PE-37233_AddCompilerTestMatrix branch May 14, 2024 16:42
ragingra added a commit that referenced this pull request Jul 29, 2024
Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler
ragingra added a commit that referenced this pull request Jul 29, 2024
Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler
CoMfUcIoS pushed a commit that referenced this pull request Sep 2, 2024
Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler
CoMfUcIoS pushed a commit that referenced this pull request Sep 9, 2024
Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler
CoMfUcIoS added a commit that referenced this pull request Sep 12, 2024
* (PE-37236) Remove experimental status of add_compiler (#428)

* (PE-37233) Adding add_compiler to test matrix (#434)

Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler

* (PE-38814) add_compiler - Making primary_postgresql_host and avail_group_letter optional (#468)

* (PE-38814) add_compiler - Making primary_postgresql_host and avail_group_letter optional

primary_postgresql_host, if not provided will be determined through get_peadm_config
avail_group_letter, is defaulting to A

* Updating spec tests for add compiler

Removing optional from avail_group_letter as not required with enum default value

* Updating reference.md

* Fixing linting issues

---------

Co-authored-by: Neil Anderson <neil.anderson@perforce.com>

* (PE-37235) Verify and update documentation on add_compiler (#429)

* PE-37235 Verify and update documentation on add_compiler if needed and its experimental status

* @cathal41
PE-37235 Verify and update documentation on add_compiler - wording updates

* Update plans/add_compiler.pp

Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>

* Updating add compiler docs to show optional params

* Updating docs with text corrections

---------

Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>
Co-authored-by: Neil Anderson <neil.anderson@perforce.com>

* chore(workflows): simplify YAML syntax and improve readability

- Removed unnecessary quotes around strings in YAML files.
- Consolidated list items to single-line format where applicable.
- Ensured consistent naming conventions for job steps.
- Improved readability by removing extra blank lines.

* fix(workflow): add console_password to test-add-compiler workflows

- Added `console_password` parameter to the `test-add-compiler-matrix.yml` and `test-add-compiler.yaml` workflows.
- This ensures the console password is passed correctly during the workflow execution.

* chore: update test-add-compiler-matrix workflow

- Remove centos-7 from the image matrix in test-add-compiler-matrix.yml
- Retain only almalinux-cloud/almalinux-8 in the image matrix

* feat(workflow): add --stream option to bolt plan run command

Added the --stream option to the bolt plan run command in the test-add-compiler GitHub workflow. This change ensures that the output is streamed in real-time.

* chore(workflow): update compiler versions in test-add-compiler-matrix.yml

Updated the compiler versions in the test-add-compiler-matrix.yml GitHub workflow from 2021.7.7 and 2023.6.0 to 2021.7.9 and 2023.8.0.

---------

Co-authored-by: Jo Lillie <jo.lillie@puppet.com>
Co-authored-by: Neil Anderson <ragingra@users.noreply.github.com>
Co-authored-by: Neil Anderson <neil.anderson@perforce.com>
Co-authored-by: cathal41 <62099613+cathal41@users.noreply.github.com>
Co-authored-by: Dimitri Tischenko <1586813+timidri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants