Release prep v3.20.0 #449
Merged
Release prep v3.20.0 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bastelfreak
reviewed
Jul 1, 2024
Comment on lines
+18
to
+20
| - [ITHELP-87329] Update test-backup-restore.yaml [#447](https://github.com/puppetlabs/puppetlabs-peadm/pull/447) ([binford2k](https://github.com/binford2k)) | ||
| - [ITHELP-87329] Update test-backup-restore.yaml [#446](https://github.com/puppetlabs/puppetlabs-peadm/pull/446) ([binford2k](https://github.com/binford2k)) | ||
| - (PE-37233) Adding add_compiler to test matrix [#434](https://github.com/puppetlabs/puppetlabs-peadm/pull/434) ([ragingra](https://github.com/ragingra)) |
There was a problem hiding this comment.
I'm not a big fan of jira keys that reference internal tickets. It's always annoying when those contain more information but to the majority of people the information isn't accessible.
There was a problem hiding this comment.
Usually the commit title and description should cover the general purpose and what has changed. Unfortunately not perfect not having public visibility of the Jira tickets, but just for internal tracking.
ragingra
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated release-prep through pdk-templates from commit 9cb918e.
Please verify before merging: