(PE-39412) PEADM should be able to add multiple compilers at once without requiring service restarts on Primary #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed `peadm::add_compiler` plan to `peadm::add_compilers` to support adding multiple compilers. - Updated parameter `compiler_host` to `compiler_hosts` to accept an array of compiler targets. - Modified `dns_alt_names` parameter to accept an array of strings, each representing a comma-separated list of DNS alt names. - Updated all references in documentation and tests to reflect the new plan name. - Enhanced the plan to handle multiple compilers in parallel, including updating PostgreSQL configurations and running necessary tasks on each compiler. BREAKING CHANGE: The plan `peadm::add_compiler` has been renamed to `peadm::add_compilers` and now supports adding multiple compilers simultaneously.
- Introduced a new plan `peadm::add_compiler` as a proxy for `peadm::add_compilers`. - Added documentation for the new plan in REFERENCE.md. - Parameters include `avail_group_letter`, `compiler_host`, `dns_alt_names`, `primary_host`, and `primary_postgresql_host`. - The plan outputs a deprecation message and calls `peadm::add_compilers` with the provided parameters.
ragingra
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
peadm::add_compilerplan topeadm::add_compilersto support adding multiple compilers.compiler_hosttocompiler_hoststo accept an array of compiler targets.dns_alt_namesparameter to accept an array of strings, each representing a comma-separated list of DNS alt names.BREAKING CHANGE: The plan
peadm::add_compilerhas been renamed topeadm::add_compilersand now supports adding multiple compilers simultaneously.Related Issues (if any)
#335
Checklist
Changes include test coverage?
Have you updated the documentation?