Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): add random hash generation for console password in test-legacy-upgrade #513

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

CoMfUcIoS
Copy link
Contributor

@CoMfUcIoS CoMfUcIoS commented Oct 9, 2024

  • Added a step to generate a random hash for the console password using /dev/urandom.
  • Updated the params.json creation to use the generated hash instead of a fixed secret.
  • Ensured the hash is printed for debugging purposes.## Summary
    Provide a detailed description of all the changes present in this pull request.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

…st-legacy-upgrade

- Added a step to generate a random hash for the console password using /dev/urandom.
- Updated the params.json creation to use the generated hash instead of a fixed secret.
- Ensured the hash is printed for debugging purposes.
- Fixed the syntax for generating a random hash for the console password using /dev/urandom.
- Ensured proper escaping of special characters in the tr command.
- Removed the push event trigger to streamline the workflow execution.
- The workflow will now only trigger on pull requests affecting .github/workflows/**/*
@CoMfUcIoS CoMfUcIoS requested review from a team as code owners October 9, 2024 14:20
@CoMfUcIoS CoMfUcIoS merged commit e17f6b5 into puppetlabs:main Oct 10, 2024
71 checks passed
@CoMfUcIoS CoMfUcIoS deleted the Fix_Fork_CI branch October 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants