Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move download_type enum to own type alias #525

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

bastelfreak
Copy link
Collaborator

@bastelfreak bastelfreak commented Nov 7, 2024

This allows users of PEADM to reuse the type and validate their input properly before calling peadm.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

This allows users of PEADM to reuse the type and validate their input
properly before calling peadm.
@bastelfreak bastelfreak self-assigned this Nov 7, 2024
@bastelfreak bastelfreak marked this pull request as ready for review November 7, 2024 09:30
@bastelfreak bastelfreak requested review from a team as code owners November 7, 2024 09:30
@bastelfreak
Copy link
Collaborator Author

@ragingra thanks a lot!

@bastelfreak bastelfreak merged commit bbc1487 into puppetlabs:main Dec 4, 2024
71 checks passed
@bastelfreak bastelfreak deleted the download_mode branch December 4, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants