(MODULES-4394) Make the module_working_dir configurable #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the module_work_dir used when installing modules fixtures via the forge used a hardcoded relative path inside of the module. However during CI testing this path gets very long and in some instances on Windows, the fixtures fail to install. This commit adds support for an environment variable called `MODULE_WORKING_DIR` which can be set and will instruct the helper to use this user set directory. This commit preserves converting the path into a Puppet compatible string due to PUP-4884. If the environment variable is not set the current default of `spec/fixtures/work-dir` is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the module_work_dir used when installing modules fixtures via the
forge used a hardcoded relative path inside of the module. However during CI
testing this path gets very long and in some instances on Windows, the fixtures
fail to install. This commit adds support for an environment variable called
MODULE_WORKING_DIRwhich can be set and will instruct the helper to use thisuser set directory. This commit preserves converting the path into a Puppet
compatible string due to PUP-4884. If the environment variable is not set the
current default of
spec/fixtures/work-diris used.