(maint) fix gettext rake tasks #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gettext rake tasks are currently looking for a locales directory in the spec_helper when they should be looking in the module root directory. A way around this is to use Dir.pwd, because rake always moves to the directory where the Rakefile is to load it, making Dir.pwd always the module root.
|
Waiting for CLA signature by @eputnam @eputnam - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
eputnam
added a commit
to eputnam/puppetlabs_spec_helper
that referenced
this pull request
Feb 23, 2017
Z release for gettext task fix puppetlabs#180
Merged
eputnam
added a commit
to eputnam/puppetlabs_spec_helper
that referenced
this pull request
Feb 23, 2017
Z release for gettext task fix puppetlabs#180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gettext rake tasks are currently looking for a locales directory in the spec_helper when they should be looking in the module root directory. A way around this is to use Dir.pwd, because rake always moves to the directory where the Rakefile is to load it, making Dir.pwd always the module root (https://github.com/ruby/rake/blob/master/lib/rake/application.rb#L685-L687)