Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-4471) Add CI_SPEC_OPTIONS environment variable to modify rspec #182

Merged

Conversation

glennsarti
Copy link
Contributor

Previously it was not possible to modify the behaviour of RSpec from the rake
tasks. This commit adds an additional environment variable called
CI_SPEC_OPTIONS which will be appended to the rspec invocation so that additional
settings, such as, output formatting can be passed into the rake tasks.

This commit also adds documentation to the README about CI_SPEC_OPTIONS.

Previously it was not possible to modify the behaviour of RSpec from the rake
tasks.  This commit adds an additional environment variable called
CI_SPEC_OPTIONS which will be appended to the rspec invocation so that additional
settings, such as, output formatting can be passed into the rake tasks.

This commit also adds documentation to the README about CI_SPEC_OPTIONS.
@puppetcla
Copy link

CLA signed by all contributors.

@DavidS
Copy link
Contributor

DavidS commented Mar 1, 2017

👍 overall. Please move the CI_NODE_COUNT description from where it is currently to the new section you added. It fits here much better, than under the "Initializing puppet" header.

This commit moves the documentation about parallel spec runs to a more
appropriate place in the README file.
@glennsarti
Copy link
Contributor Author

@DavidS Updated.

@DavidS DavidS merged commit 8dedd98 into puppetlabs:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants