Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on parallel_tests #186

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Mar 28, 2017

The rake task release_checks uses the parallel_tests so this should be
either a dependency or the task should fall back on regular tests. Given
parallel_tests works well, I decided on the former.

Note that since parallel_tests depends on ruby >= 2.0 this also means
puppetlabs_spec_helper depends on that.

The rake task release_checks uses the parallel_tests so this should be
either a dependency or the task should fall back on regular tests. Given
parallel_tests works well, I decided on the former.

Note that since parallel_tests depends on ruby >= 2.0 this also means
puppetlabs_spec_helper depends on that.
@puppetcla
Copy link

Waiting for CLA signature by @ekohl

@ekohl - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@ekohl
Copy link
Contributor Author

ekohl commented Mar 28, 2017

IMHO this is a trivial patch since it's only a metadata change.

@hunner hunner merged commit 06c7f91 into puppetlabs:master Mar 28, 2017
@ekohl ekohl deleted the add-parallel-tests-dependency branch March 28, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants