Adding a parent rake task for i18n of a module #194
Conversation
|
Waiting for CLA signature by @HelenCampbell @HelenCampbell - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
| namespace :module do | ||
| desc "Runs all tasks to build a modules POT file for internationalization" | ||
| task :i18n do | ||
| Rake::Task["gettext:metadata_pot"].invoke("#{module_dir}/metadata.json") |
There was a problem hiding this comment.
Were we also going to call gettext:pot here?
There was a problem hiding this comment.
Possibly worth while creating a ticket to ensure that when the rake task for generating the puppet strings exists, that it will be included here too.
| @@ -607,4 +607,10 @@ def max_thread_limit | |||
| rescue Gem::LoadError | |||
| puts "No gettext-setup gem found, skipping gettext initialization" if Rake.verbose == true | |||
| end | |||
| namespace :module do | |||
| desc "Runs all tasks to build a modules POT file for internationalization" | |||
| task :i18n do | |||
There was a problem hiding this comment.
maybe we should call this pot instead, so if we have other tasks related to i18n, we won't have confusion.
HelenCampbell
force-pushed
the
i18nparent
branch
2 times, most recently
from
9057ac6
to
79021ec
Compare
This will be the parent rake task to call all i18n rake tasks for a module to get it prepared for internationalization. Note that it is inside checks to ensure the module has a locales directory - a sign that the module is i18n ready.
This will be the parent rake task to call all i18n rake tasks for a module to get it prepared for internationalisation. Note that it is inside the check to ensure the module has a locales directory - a sign that the module is i18n ready.