Support CI options for parallel_spec #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjen
reviewed
Jul 14, 2017
| args = ['-t', 'rspec']. | ||
| concat(Rake::FileList[pattern].to_a) | ||
| args = ['-t', 'rspec'] | ||
| args = args.push('--').concat(ENV['CI_SPEC_OPTIONS'].split 'j').push('--') unless ENV['CI_SPEC_OPTIONS'].nil? |
There was a problem hiding this comment.
These next two lines don't need the = assignment, push and concat should modify the object directly.
|
CLA signed by all contributors. |
austb
force-pushed
the
parallel_spec_ci_opts
branch
from
e3d0388
to
474d541
Compare
austb
force-pushed
the
parallel_spec_ci_opts
branch
from
f956c88
to
75af190
Compare
bmjen
reviewed
Jul 14, 2017
| args = ['-t', 'rspec']. | ||
| concat(Rake::FileList[pattern].to_a) | ||
| args = ['-t', 'rspec'] | ||
| args.push('--').concat(ENV['CI_SPEC_OPTIONS'].split(' ')).push('--') unless ENV['CI_SPEC_OPTIONS'].nil? |
There was a problem hiding this comment.
The guard needs to also protect against an empty string or string of only whitespace. Otherwise you'll just be adding -- to args without actual args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.