Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-409) Make directory junction targets relative to the junction #203

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Aug 10, 2017

On POSIX hosts, symlinks are created relative to the symlink automatically (unless created with an absolute path), so if .fixtures.yml contains something like:

fixtures:
  symlinks:
    "test": "../../../test"

Then you end up with a link in spec/fixtures/modules that looks like:

lrwxrwxrwx  1 tsharpe tsharpe   13 Aug 10 13:29 test -> ../../../test

Directory junctions on windows behave differently in that they are created relative to the current working directory. In order to make the directory junctions behave in the expected way, this PR adjusts the directory junction target so that we prepend the directory where the junction is to be created (usually spec/fixtures/modules) to the target.

08/10/2017  03:38AM    <JUNCTION>      test [\??\C:\Users\Administrator\test-module\test]

/cc @cdenneen

@rodjek
Copy link
Contributor Author

rodjek commented Aug 10, 2017

The push travis build failed because I accidentally pushed the branch to upstream instead of my fork and then I deleted the branch before the tests finished.

@puppetcla
Copy link

CLA signed by all contributors.

@cdenneen
Copy link

@rodjek thanks for the quick turn around

@DavidS DavidS merged commit 3cd64b1 into puppetlabs:master Aug 10, 2017
@rodjek rodjek deleted the pdk-409 branch August 11, 2017 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants