Fix release_checks without parallel_tests #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:release_checks attempts :parallel_spec then :spec if it fails, with puppetlabs@920d647 this causes :spec_clean to be invoked twice if parallel_tests is not installed, but crucially it doesn't execute it twice and therefore causes check:symlinks to fail every time.
ekohl
approved these changes
Sep 12, 2017
With this change :parallel_spec only runs cleanup, if it loaded successfully
|
Waiting for CLA signature by @sean797 @sean797 - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
|
CLA signed by all contributors. |
1 similar comment
|
CLA signed by all contributors. |
|
Yes, that works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:release_checks attempts :parallel_spec then :spec if it fails, with 920d647 which causes :spec_clean to be invoked twice if parallel_tests is not installed, but crucially it doesn't execute it twice and therefore causes check:symlinks to fail every time when ran via :release_checks without parallel_tests gem