Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIN-6) trim whitespace from test_tiers before parsing #214

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

ThoughtCrhyme
Copy link
Contributor

No description provided.

@puppetcla
Copy link

Waiting for CLA signature by @ThoughtCrhyme

@ThoughtCrhyme - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@@ -61,6 +61,7 @@
test_tiers = ENV['TEST_TIERS'].split(',')
raise 'TEST_TIERS env variable must have at least 1 tier specified. low, medium or high (comma separated).' if test_tiers.count == 0
test_tiers.each do |tier|
tier.to_s.strip
Copy link
Contributor

@eputnam eputnam Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pretty nitpicky, but is to_s required here? i'm genuinely curious as i'm often missing something.

[5] pry(main)> aryy = ENV['TEST'].split(',')
=> ["testing", "testing2", "testing3"]
[6] pry(main)> aryy.each do |i|
[6] pry(main)*   puts i.class
[6] pry(main)* end
String
String
String
=> ["testing", "testing2", "testing3"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants