(PDK-1033) Use --unshallow when fetching a ref
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdenneen does this fix your issues? |
|
CLA signed by all contributors. |
rodjek
force-pushed
the
pdk-1033-git---unshallow
branch
2 times, most recently
from
c41a3e3
to
b39a501
Compare
git does not fetch beyond the original depth in shallow repositories. This change uses `--unshallow` when a `ref` is specified, to avoid the issues shown in PDK-1033, namely not being able to switch from a shallow non-`ref` fixture clone to one with a `ref` to outside the original clone.
rodjek
force-pushed
the
pdk-1033-git---unshallow
branch
from
b39a501
to
9b87f3f
Compare
|
This is "better" but still not 100% First run through I ran the spec_prep and got the following error: Second run through Also note getting the following warning on both runs Another thing I've noticed is sometimes on subsequent |
|
CLA signed by all contributors. |
|
@cdenneen are you maybe seeing into https://tickets.puppetlabs.com/browse/PDK-1031 ? |
|
@DavidS That definitely might be the "Symlink" weirdness. Also did another |
|
That's weird. Do the clones actually look like clones, or did it just create an empty directory (which is enough for PSH to skip them). |
|
it was the threading... was hiding a fixture that was changed from Once i deleted the fixture module it worked fine. Also subsequent run works clean as well. So threading was hiding the underlying issue. |
rodjek
force-pushed
the
pdk-1033-git---unshallow
branch
from
de3a5f2
to
2cb81af
Compare
rodjek
force-pushed
the
pdk-1033-git---unshallow
branch
from
2cb81af
to
4e8e992
Compare
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 39.37% 39.16% -0.22%
==========================================
Files 10 10
Lines 706 720 +14
==========================================
+ Hits 278 282 +4
- Misses 428 438 +10
Continue to review full report at Codecov.
|
|
The threadsafe issue is being handled in #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git does not fetch beyond the original depth in shallow repositories. This change uses
--unshallowwhen arefis specified, to avoid the issues shown in PDK-1033, namely not being able to switch from a shallow non-reffixture clone to one with arefto outside the original clone.