Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tasks to rspec pattern. #261

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

dylanratcliffe
Copy link
Contributor

While I have yet to see anyone testing ruby tasks, I see no reason why we should prevent that.

While I have yet to see anyone testing ruby tasks, I see no reason why we should prevent that.
@dylanratcliffe
Copy link
Contributor Author

Also changed to alphabetical order

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   40.46%   40.46%           
=======================================
  Files          10       10           
  Lines         734      734           
=======================================
  Hits          297      297           
  Misses        437      437
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 41.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8780f...9bc2dfb. Read the comment docs.

@DavidS DavidS requested a review from rodjek October 8, 2018 09:33
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @rodjek will this interfere with any (future) rspec-puppet task testing?

@puppetcla
Copy link

CLA signed by all contributors.

Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidS I currently have no plans in regards to implementing task specs in rspec-puppet. That said, if/when it does happen, that would be the path I'd choose to put them under anyway so 👍

@DavidS DavidS merged commit 128b379 into puppetlabs:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants