(PDK-1137) Determine module name from metadata when possible #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 40.34% 40.97% +0.62%
==========================================
Files 10 10
Lines 751 759 +8
==========================================
+ Hits 303 311 +8
Misses 448 448
Continue to review full report at Codecov.
|
|
CLA signed by all contributors. |
DavidS
approved these changes
Nov 26, 2018
bmjen
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the automatic symlink fixture, determine the module name from the contents of
metadata.jsonif possible and fall back to looking at the name of the working directory. This clears up the error reported in PDK-1137 where appveyor was converting the underscores in the repo name into dashes when cloning.