Revert "(MODULES-8242) - Fix CI_SPEC_OPTIONS failing" #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
scotje
approved these changes
Jan 15, 2019
bmjen
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #268 as this change breaks the documented behaviour. The
CI_SPEC_OPTIONSenvironment variable is used for passing RSpec options into the rake task. In MODULES-8242 the user was attempting to pass parallel_tests options in this environment variable, which won't work and was mistaken for a bug. The behaviour now means that any RSpec options passed in this environment variable will cause the task to fail where it previously worked.We should revert this change and then extend the logic to pass in parallel_tests options in a separate environment variable, split and push onto the
argsarray before the options fromCI_SPEC_OPTIONS./cc @scotje