Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --color from everywhere, use RSpec default detection instead #280

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Feb 15, 2019

RSpec 3 defaults to using color when possible, and people can override
this setting in their $HOME\.rspec if required.

This fixes #170

RSpec 3 defaults to using color when possible, and people can override
this setting in their `$HOME\.rspec` if required.

This fixes puppetlabs#170
@DavidS DavidS changed the title Remove --color from everywhere Remove --color from everywhere, use RSpec default detection instead Feb 15, 2019
@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #280 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   44.45%   44.45%           
=======================================
  Files          11       11           
  Lines         776      776           
=======================================
  Hits          345      345           
  Misses        431      431
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 46.34% <0%> (ø) ⬆️
lib/puppetlabs_spec_helper/tasks/beaker.rb 52.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e502d1a...64ce0aa. Read the comment docs.

@puppetcla
Copy link

CLA signed by all contributors.

@tphoney tphoney merged commit 33247c8 into puppetlabs:master Feb 19, 2019
@DavidS DavidS deleted the default-to-rspec-behaviour branch May 2, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants