-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: metadata dependencies are auto installed #291
Feature: metadata dependencies are auto installed #291
Conversation
CLA signed by all contributors. |
7669b6f
to
b078b95
Compare
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 44.88% 42.04% -2.84%
==========================================
Files 11 12 +1
Lines 782 849 +67
==========================================
+ Hits 351 357 +6
- Misses 431 492 +61
Continue to review full report at Codecov.
|
0f3db62
to
dfec662
Compare
Adding support to install modules from remote Puppet Forge, automatically, by reading contents of `metadata.json`. There are some configuration options added, like option to define `forge` address. Automatic installation is disabled by default to keep backward compatibility - in next major version it should be enabled by default. Adding installed module tree display after dependencies installation. Added more tests, including acceptance, so that rake spec using this module will be asserted.
dfec662
to
d337c07
Compare
@Cosaquee I'm notifying you as you always wanted this feature 😉 |
Due to PUP-9813 installation is rather slow. Merging PR puppetlabs/puppet#7602 should provide a walkaround, until minitar performance can be enhanced. |
#284 should speed up the downloads greatly. |
But it's not download that are a problem but extraction of archives. Especially large like stdlib. Parallel execution might help, but not with this PR as it pass installation of modules and their dependencies to puppet. |
Hi @cardil, this looks nice! Can you rebase it, please ? Thank you! Cheers! |
As much as I'd like to have the changes, I've tried rebasing this and didn't get anywhere as the core changes in fixtures download are clashing hard with the other changes that have went in. If anyone gets around to resurrecting this code, please do open a new PR referencing this one. |
Auto-Install of dependencies based on metadata.json info
Adding support to install modules from remote Puppet Forge, automatically, by reading contents of
metadata.json
. There are some configuration options added, like option to defineforge
address. Automatic installation is disabled by default to keep backward compatibility - in next major version it should be enabled by default.Actual default value is:
Additionally: