Support git fixture branches containing slashes #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, checking out git feature branches containing slashes would consistently fail. This modifies the command to unambiguously point to origin.
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=======================================
Coverage 43.75% 43.75%
=======================================
Files 11 11
Lines 825 825
=======================================
Hits 361 361
Misses 464 464
Continue to review full report at Codecov.
|
|
CLA signed by all contributors. |
DavidS
approved these changes
Nov 15, 2019
glennsarti
added a commit
to glennsarti/puppetlabs_spec_helper
that referenced
this pull request
Jan 31, 2020
Previously if you added a ref with a forward slash, which is common in branch names, this would fail in a strange way. This commit adds early detection of forward slashes and returns a helpful error message.
glennsarti
added a commit
to glennsarti/puppetlabs_spec_helper
that referenced
this pull request
Jan 31, 2020
Previously if you added a ref with a forward slash, which is common in branch names, this would fail in a strange way. This commit adds early detection of forward slashes and returns a helpful error message.
glennsarti
added a commit
to glennsarti/puppetlabs_spec_helper
that referenced
this pull request
Feb 4, 2020
Previously if you added a ref with a forward slash, which is common in branch names, this would fail in a strange way. This commit adds early detection of forward slashes and returns a helpful error message.
glennsarti
added a commit
that referenced
this pull request
Feb 4, 2020
(GH-297) Don't allow git refs with forward slashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, checking out git feature branches containing slashes would
consistently fail.
This modifies the command to unambiguously point to origin.