Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset when target is missing #30

Merged
merged 2 commits into from
Apr 24, 2013
Merged

Conversation

hunner
Copy link
Contributor

@hunner hunner commented Dec 28, 2012

If the target repository clone does not exist (when ^C was pressed, for
example) then the cd command will fail, but the git reset will still
be run. This will reset the current working dir from which rake was
ran to be reset to ref. This commit keeps that from happening.

@puppetcla
Copy link

CLA Signed by hunner on 2010-12-16 21:00:00 -0800

If the target repository clone does not exist (when ^C was pressed, for
example) then the `cd` command will fail, but the `git reset` will still
be run. This will reset the current working dir from which `rake` was
ran to be reset to `ref`. This commit keeps that from happening.
Previous behaviour was to use the default upstream branch which may be
different than `master`. This commit reverts back to previously defined
behaviour, allowing alternative upstream branches to be used.
branan pushed a commit that referenced this pull request Apr 24, 2013
Don't reset when target is missing
@branan branan merged commit 14ad7de into puppetlabs:master Apr 24, 2013
@hunner hunner deleted the no_ref branch June 6, 2014 17:11
@chelnak chelnak added the bug label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants