Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check task #327

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Add a check task #327

merged 2 commits into from
Jan 11, 2021

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Dec 8, 2020

This forms a combination of all check tasks which makes it easy to run it locally or in CI. The release_checks task is also modified to use it instead.

@ekohl ekohl requested review from a team as code owners December 8, 2020 16:52
This forms a combination of all check tasks which makes it easy to run
it locally or in CI. The release_checks task is also modified to use it
instead.
@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #327 (9a19f23) into master (dd3a000) will increase coverage by 0.28%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   42.99%   43.28%   +0.28%     
==========================================
  Files          11       11              
  Lines         842      841       -1     
==========================================
+ Hits          362      364       +2     
+ Misses        480      477       -3     
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 41.46% <66.66%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3a000...9a19f23. Read the comment docs.

@sheenaajay
Copy link
Contributor

@sheenaajay sheenaajay merged commit 172300a into puppetlabs:master Jan 11, 2021
@ekohl ekohl deleted the check-task branch February 23, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants