-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beaker integration #338
Conversation
Today there's both beaker and litmus. The spec helper shouldn't be opinionated. For beaker integration, I'd prefer to make this easy to consume. beaker-rspec[1] can provide useful helpers. There is already beaker-rspec/rake_task[2] which feels like a more native place. In Voxpupuli there's also voxpupuli-acceptance[3] which is a potential place. [1] https://github.com/voxpupuli/beaker-rspec [2] https://github.com/voxpupuli/beaker-rspec/blob/master/lib/beaker-rspec/rake_task.rb [3] https://github.com/voxpupuli/voxpupuli-acceptance
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 43.28% 43.08% -0.21%
==========================================
Files 11 10 -1
Lines 841 766 -75
==========================================
- Hits 364 330 -34
+ Misses 477 436 -41
Continue to review full report at Codecov.
|
Hi @ekohl thanks for raising this. We're looking into whether it's possibile to make thi beaker code an optional include so that this doesnt affect existing users who may make use of the functionality. |
Isn't that easy? I opened #339 but right now I can't easily test it (upgraded to Fedora 34 with Ruby 3). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Apologies on the delay, my fault entirely
Does this mean the next version is a major version bump? |
Today there's both beaker and litmus. The spec helper shouldn't be opinionated. For beaker integration, I'd prefer to make this easy to consume.
beaker-rspec[1] can provide useful helpers. There is already beaker-rspec/rake_task[2] which feels like a more native place.
In Voxpupuli there's also voxpupuli-acceptance[3] which is a potential place.
[1] https://github.com/voxpupuli/beaker-rspec
[2] https://github.com/voxpupuli/beaker-rspec/blob/master/lib/beaker-rspec/rake_task.rb
[3] https://github.com/voxpupuli/voxpupuli-acceptance