Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beaker integration #338

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented May 21, 2021

Today there's both beaker and litmus. The spec helper shouldn't be opinionated. For beaker integration, I'd prefer to make this easy to consume.

beaker-rspec[1] can provide useful helpers. There is already beaker-rspec/rake_task[2] which feels like a more native place.

In Voxpupuli there's also voxpupuli-acceptance[3] which is a potential place.

[1] https://github.com/voxpupuli/beaker-rspec
[2] https://github.com/voxpupuli/beaker-rspec/blob/master/lib/beaker-rspec/rake_task.rb
[3] https://github.com/voxpupuli/voxpupuli-acceptance

Today there's both beaker and litmus. The spec helper shouldn't be
opinionated. For beaker integration, I'd prefer to make this easy to
consume.

beaker-rspec[1] can provide useful helpers. There is already
beaker-rspec/rake_task[2] which feels like a more native place.

In Voxpupuli there's also voxpupuli-acceptance[3] which is a potential
place.

[1] https://github.com/voxpupuli/beaker-rspec
[2] https://github.com/voxpupuli/beaker-rspec/blob/master/lib/beaker-rspec/rake_task.rb
[3] https://github.com/voxpupuli/voxpupuli-acceptance
@codecov-commenter
Copy link

Codecov Report

Merging #338 (bbea4a6) into main (cbad6f4) will decrease coverage by 0.20%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   43.28%   43.08%   -0.21%     
==========================================
  Files          11       10       -1     
  Lines         841      766      -75     
==========================================
- Hits          364      330      -34     
+ Misses        477      436      -41     
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/puppet_spec_helper.rb 65.51% <ø> (ø)
lib/puppetlabs_spec_helper/tasks/fixtures.rb 38.36% <ø> (ø)
lib/puppetlabs_spec_helper/rake_tasks.rb 43.22% <80.00%> (+1.75%) ⬆️
...bs_spec_helper/puppetlabs_spec/puppet_internals.rb 92.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad0332...bbea4a6. Read the comment docs.

@da-ar
Copy link

da-ar commented May 24, 2021

Hi @ekohl thanks for raising this. We're looking into whether it's possibile to make thi beaker code an optional include so that this doesnt affect existing users who may make use of the functionality.

@ekohl
Copy link
Contributor Author

ekohl commented May 25, 2021

Isn't that easy? I opened #339 but right now I can't easily test it (upgraded to Fedora 34 with Ruby 3).

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Apologies on the delay, my fault entirely

@jpogran jpogran merged commit a3b2473 into puppetlabs:main Jun 15, 2021
@ekohl ekohl deleted the remove-beaker-integration branch June 15, 2021 14:34
@ekohl
Copy link
Contributor Author

ekohl commented Jun 15, 2021

Does this mean the next version is a major version bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants