(CONT-237) Deprecation and legacy version support removal #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-237-clean_up_deprecations
branch
from
116f5d9
to
600941e
Compare
pmcmaw
approved these changes
Oct 25, 2022
ekohl
reviewed
Jan 23, 2023
Comment on lines
+29
to
+38
| spec.required_ruby_version = Gem::Requirement.new('>= 2.7') | ||
|
|
||
| spec.add_runtime_dependency 'mocha', '~> 1.0' | ||
| spec.add_runtime_dependency 'pathspec', '~> 1.0' | ||
| spec.add_runtime_dependency 'puppet-lint', '~> 3.0' | ||
| spec.add_runtime_dependency 'puppet-syntax', '~> 3.0' | ||
| spec.add_runtime_dependency 'rspec-github', '~> 2.0' | ||
| spec.add_runtime_dependency 'rspec-puppet', '~> 2.0' | ||
|
|
||
| spec.requirements << 'puppet, >= 6.0.0' |
There was a problem hiding this comment.
Late to the party, but AFAIK Puppet 6 doesn't run on Ruby 2.7. I'd expect either Ruby 2.5 + Puppet 6 or Ruby 2.7 + Puppet 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of deprecation removals. Additionally we are also removing any code paths that refer to puppet versions less than v6. Suitable defaults have been provided where applicable.