Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-515) Fix uninitialized constant error #379

Merged
merged 3 commits into from
Jan 25, 2023
Merged

(CONT-515) Fix uninitialized constant error #379

merged 3 commits into from
Jan 25, 2023

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Jan 23, 2023

This PR fixes the following error:

NameError: uninitialized constant PuppetlabsSpecHelper
/home/runner/work/pdk/pdk/vendor/bundle/ruby/2.7.0/gems/puppetlabs_spec_helper-5.0.1/lib/puppetlabs_spec_helper/tasks/fixtures.rb:8:in `<top (required)>'
/home/runner/work/pdk/pdk/Rakefile:3:in `require'
/home/runner/work/pdk/pdk/Rakefile:3:in `<top (required)>'
/home/runner/work/pdk/pdk/vendor/bundle/ruby/2.7.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
/opt/hostedtoolcache/Ruby/2.7.7/x[6](https://github.com/puppetlabs/pdk/actions/runs/3989741069/jobs/6842538417#step:7:7)4/bin/bundle:23:in `load'
/opt/hostedtoolcache/Ruby/2.[7](https://github.com/puppetlabs/pdk/actions/runs/3989741069/jobs/6842538417#step:7:8).7/x64/bin/bundle:23:in `<main>'

@chelnak chelnak added the bug label Jan 23, 2023
@chelnak chelnak self-assigned this Jan 23, 2023
@chelnak chelnak requested a review from a team as a code owner January 23, 2023 19:27
@chelnak chelnak force-pushed the CONT-515-fix_uninitialized_constant_error branch 2 times, most recently from d00f2e0 to 2115d67 Compare January 25, 2023 10:02
ekohl
ekohl reviewed Jan 25, 2023
View reviewed changes
lib/puppetlabs_spec_helper/tasks/fixtures.rb Outdated Show resolved Hide resolved
lib/puppetlabs_spec_helper/tasks/fixtures.rb Outdated Show resolved Hide resolved
lib/puppetlabs_spec_helper/tasks/fixtures.rb Outdated Show resolved Hide resolved
bastelfreak
bastelfreak approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. also thousand times more readable without the whitespace: https://github.com/puppetlabs/puppetlabs_spec_helper/pull/379/files?diff=unified&w=1

@chelnak
(CONT-515) Fix uninitialized constant error
9aad607
@chelnak
(MAINT) Update rubocop config
8a816ec 
This commit allows rubocop to use the default of nested for the
ClassAndModuleChildren cop.
@chelnak chelnak force-pushed the CONT-515-fix_uninitialized_constant_error branch from d4a0424 to 8a816ec Compare January 25, 2023 10:24
@david22swan david22swan merged commit ddf19d5 into main Jan 25, 2023
@david22swan david22swan deleted the CONT-515-fix_uninitialized_constant_error branch January 25, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

@david22swan david22swan david22swan approved these changes

Assignees

@chelnak chelnak

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chelnak @ekohl @bastelfreak @david22swan