Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1256)- Require puppetlabs-puppet-lint over puppet-lint #411

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

GSPatton
Copy link
Contributor

@GSPatton GSPatton commented Oct 5, 2023

Note: This PR is pending the creation of the new puppetlabs-puppet-lint gem

Updating the puppet-lint runtime dependency with the new puppet-lint gem in the puppetlabs namespace. Modules will consume this gem from spec_helper.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Updating the puppet-lint runtime dependency with the new puppet-lint gem in the puppetlabs namespace. Modules will consume this gem from spec_helper.
@GSPatton GSPatton force-pushed the CAT-1256-Roll_out_new_puppet_lint_gem branch from 9f4ce02 to fb7acc3 Compare October 10, 2023 08:14
@GSPatton GSPatton closed this Oct 10, 2023
@GSPatton GSPatton reopened this Oct 10, 2023
@GSPatton GSPatton closed this Oct 18, 2023
@GSPatton GSPatton reopened this Oct 18, 2023
@GSPatton GSPatton marked this pull request as ready for review October 18, 2023 11:11
@GSPatton GSPatton requested review from bastelfreak and a team as code owners October 18, 2023 11:11
@bastelfreak
Copy link
Collaborator

same question here, should we mark it as breaking change?

@GSPatton
Copy link
Contributor Author

@bastelfreak yep :) we were just discussing this. Thanks

@jordanbreen28 jordanbreen28 merged commit 090072c into main Oct 18, 2023
8 checks passed
@jordanbreen28 jordanbreen28 deleted the CAT-1256-Roll_out_new_puppet_lint_gem branch October 18, 2023 11:17
@jordanbreen28 jordanbreen28 changed the title (CAT-1256) Roll out new puppet-lint gem (CAT-1256)- Require puppetlabs-puppet-lint over puppet-lint Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants