(CAT-1222) - Require puppetlabs-rspec-puppet over rspec-puppet #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
CAT-1222-require_puppetlabs-rspec-puppet
branch
3 times, most recently
from
b0858db
to
f41dc6e
Compare
this commit requires the newer puppetlabs-rspec-puppet (official puppet supported) over rspec-puppet. (no longer puppet supported)
jordanbreen28
force-pushed
the
CAT-1222-require_puppetlabs-rspec-puppet
branch
from
f41dc6e
to
1f6c13e
Compare
|
@LukasAud should we mark this as breaking change or is it only a feature? (I'm unsure but tend to to breaking change). |
|
@bastelfreak I actually agree, breaking change is more appropriate. Will update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this PR requires the newer puppetlabs-rspec-puppet (official puppet supported) over rspec-puppet. (no longer officially supported by puppet).
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist